[LABS-495] Add condition drivers for magic conditions - #21390
Open
Quexington wants to merge 1 commit into
Open
Quexington wants to merge 1 commit into
Quexington wants to merge 1 commit into
Conversation
Contributor
|
Coverage Report for CI Build 34535459537Warning No base build found for commit Coverage: 90.224%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes how CAT, NFT, and VC transactions assemble on-chain conditions; incorrect serialization would break mempool acceptance, though tests assert program equivalence with the old manual encoding.
Overview
Introduces typed
Conditiondrivers so wallet spend construction no longer hand-buildsUnknownConditionwith raw CLVM opcodes and argument lists.CAT: Adds
TAILConditionincat_utilsand switches CAT/CR-CAT wallets, TAIL mint helpers, and related tests to use it withUnknownPuzzle/UnknownSolutionfor the -113 TAIL assertion on create-coin.NFT: Adds
UpdateMetadataCondition(-24 metadata updater) andTransferProgramCondition(-10 ownership transfer program). NFT wallet spends andcreate_ownership_layer_transfer_solutionnow emit these types; trade prices are modeled as adict[bytes32, int]instead of nested lists.VC: Adds
MagicTPConditionfor exigent-metadata-layer -10 conditions.VerifiedCredentialhelpers (magic_condition_for_new_proofs,standard_magic_condition,magic_condition_for_self_revoke) return this type directly instead of barePrograms wrapped inUnknownCondition.from_program.Unit tests cover
to_program/from_programroundtrips for the new drivers; lifecycle tests were updated to match.Reviewed by Cursor Bugbot for commit c4144cb. Bugbot is set up for automated code reviews on this repo. Configure here.