[LABS-493] Add drivers for common puzzle types - #21373
Merged
Merged
Conversation
Quexington
had a problem deploying
to
windows-code-signing
September 8, 2026 22:38 — with
GitHub Actions
Error
Quexington
had a problem deploying
to
windows-code-signing
September 8, 2026 22:42 — with
GitHub Actions
Error
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 74ea16b. Configure here.
Quexington
temporarily deployed
to
windows-code-signing
September 8, 2026 22:52 — with
GitHub Actions
Inactive
Quexington
had a problem deploying
to
windows-code-signing
September 9, 2026 20:48 — with
GitHub Actions
Error
Quexington
temporarily deployed
to
windows-code-signing
September 9, 2026 20:55 — with
GitHub Actions
Inactive
richardkiss
self-requested a review
September 10, 2026 01:35
richardkiss
previously approved these changes
Sep 10, 2026
Quexington
had a problem deploying
to
windows-code-signing
September 10, 2026 20:29 — with
GitHub Actions
Error
Coverage Report for CI Build 34896409727Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-0.08%) to 90.178%Details
Uncovered Changes
Coverage Regressions86 previously-covered lines in 31 files lost coverage.
Coverage Stats💛 - Coveralls |
emlowe
approved these changes
Sep 15, 2026
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Wide refactor of spend construction across pooling, VC, and CAT flows; behavior should be equivalent but any encoding mistake would affect on-chain spends.
Overview
Introduces typed puzzle drivers for common CLVM patterns:
P2Conditions(pay-to-conditions inner puzzles),ACSPuzzle/ACSSolution(always-succeed puzzle and condition-list solutions), andNilPuzzle/NilSolution, each withmatch()parsing fromUnknownPuzzle/UnknownSolution. A smallDRIVER_REGISTRYlists these driver pairs for future use.The bulk of the PR migrates wallet code and tests away from hand-built
Program.to((1, …))tuples and raw opcode lists towardCreateCoin/ otherConditiontypes plus.programfrom the new drivers. Production paths updated include PlotNFT drivers/wallet, VC/CR-CAT drivers, data layer wallet, and DID recovery puzzles.Tests gain coverage for ACS, Nil, and P2Conditions matching;
VerifiedCredential.launchmemo typing widens fromlist[bytes32]tolist[bytes].Reviewed by Cursor Bugbot for commit a5989d6. Bugbot is set up for automated code reviews on this repo. Configure here.