Remove config keys that nothing reads from initial-config.yaml - #21279
Draft
richardkiss wants to merge 2 commits into
Draft
Remove config keys that nothing reads from initial-config.yaml#21279richardkiss wants to merge 2 commits into
richardkiss wants to merge 2 commits into
Conversation
Eight keys in the default config template are read by no code. Dated by when their readers were removed: ssh_filename (SSH UI deleted Mar 2020), pool_share_threshold / ips_estimate / max_connection_time (Jan 2021), nft_metadata_cache_path + _hash_length (reader reverted in Chia-Network#13660, Oct 2022), peer_db_path / wallet_peers_path (migration removed in Chia-Network#17517, Feb 2024; both were already comment-marked deprecated). Template-only change: existing user configs are unaffected; new installs stop inheriting dead keys. The GUI repo was searched for all eight keys (GitHub code search): zero references. Co-authored-by: Cursor <cursoragent@cursor.com>
richardkiss
added
the
Changed
richardkiss
temporarily deployed
to
windows-code-signing
August 14, 2026 20:42 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Coverage Report for CI Build 31839108914Warning No base build found for commit Coverage: 92.094%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
Removes dead/unused configuration keys from the default initial-config.yaml template so new installs no longer inherit settings that are not read anywhere in the current codebase.
Changes:
- Removed unused
pool_share_thresholdfromfarmer. - Removed unused
ips_estimate/max_connection_timefromtimelord.vdf_clients. - Removed deprecated/unused
peer_db_path,ssh_filename,nft_metadata_cache_*, andwallet_peers_pathtemplate entries.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
258
to
260
| - *self_hostname | ||
| - localhost | ||
| - 127.0.0.1 |
richardkiss
marked this pull request as draft
August 22, 2026 00:41
Co-authored-by: Cursor <cursoragent@cursor.com>
richardkiss
temporarily deployed
to
windows-code-signing
August 22, 2026 01:24 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eight keys in the default config template are read by no code anywhere (
chia/,tools/,benchmarks/, tests — checked by grepping every template key against the codebase). Dated withgit log -Sover full history including the pre-2021src/era:ssh_filenameuie83aa36b"remove SSH ui and dependencies") — outlived its feature by 6 yearspool_share_thresholdfarmerips_estimatetimelordmax_connection_timetimelordnft_metadata_cache_path,nft_metadata_cache_hash_lengthwalletpeer_db_pathfull_nodewallet_peers_pathwalletAlso searched Chia-Network/chia-blockchain-gui via GitHub code search for all eight keys: zero references.
Template-only change (-16 lines, one file): existing user configs keep whatever keys they have (ignored today, ignored after); new installs stop inheriting dead keys.
daemon_hostand everything else in theuisection is untouched.Gates run locally: YAML parses;
chia/_tests/core/util/test_config.py10/10 passed.Made with Cursor