Skip to content

Fix false critical on OMD backup job when check is delayed with more than 30 seconds #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tr3pan
Copy link

@tr3pan tr3pan commented Jul 31, 2025

There is already a partial fix in #711

But issue still can happen if the CheckMK check runs delayed more 30 seconds. For example the scheduled backup is at 01:00:00, but the checkmk check for 00:59 happens at 00:59:46 for example. next_run < time.time() + 30 will be true since the next_run time is still from yesterday's backup.

I think 60 seconds is enough buffer, but adding additional 60 just to be on the safe side. The mkbackup command is scheduled by cron and if it is known the upper bound of when the backup changes its status, then the buffer time can be lowered.

Copy link

github-actions bot commented Jul 31, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@tr3pan
Copy link
Author

tr3pan commented Jul 31, 2025

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants