Skip to content

Avoid crash on failure to parse int in emerson_temp discovery. #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Avoid crash on failure to parse int in emerson_temp discovery. #818

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32bef74
Avoid crash on failure to parse int in emerson_temp discovery.
indigoparadox May 14, 2025
acff302
Filter emerson_temp to known temperature OIDs only.
indigoparadox May 19, 2025
6d8fe59
Restructure emerson_temp parsing to handle empty input.
indigoparadox May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmk/base/legacy_checks/emerson_temp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def check_emerson_temp(item, params, info):


def parse_emerson_temp(string_table: StringTable) -> StringTable:
return string_table
return [[x] for x in string_table[0]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many ways of doing this, obviously, but this way a test is failing that ensures we can deal with an emtpy input. I suggest to leave line 52 alone, add a comment, and do this:

def parse_...
    # we only use at most the first two lines because....
    return string_table[:2]



check_info["emerson_temp"] = LegacyCheckDefinition(
Expand All @@ -49,7 +49,7 @@ def parse_emerson_temp(string_table: StringTable) -> StringTable:
detect=startswith(".1.3.6.1.4.1.6302.2.1.1.1.0", "Emerson Network Power"),
fetch=SNMPTree(
base=".1.3.6.1.4.1.6302.2.1.2",
oids=["7"],
oids=["7.1", "7.2"],
),
service_name="Temperature %s",
discovery_function=inventory_emerson_temp,
Expand Down
Loading