Skip to content

invert ssl verify query #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

invert ssl verify query #791

wants to merge 1 commit into from

Conversation

lagrip
Copy link

@lagrip lagrip commented Feb 17, 2025

Thank you for your interest in contributing to Checkmk!
Consider looking into Readme regarding process details.

General information

SMS Api with "Ignore to check SSL" fails because the query code is wrong.

Bug reports

Please include:

  • Your operating system name and version
    • Ubuntu 24.04
  • Detailed steps to reproduce the bug
    • Configure Notification via SMS Api. Use https.
    • Tick "Disable SSL certificate verification"
    • Trigger a notification

Proposed changes

Sometimes it is hard for us to assess the quality of a fix.
While it may work for you, it is our job to ensure that it works for everybody.
These are some ways to help us:

  • What is the expected behavior?
    • Get the SMS notification
  • What is the observed behavior?
    • Error complaining about the ssl certificate
  • Workaround: Do not tick "Disable SSL certificate verification" and use https anyway
  • If it's not obvious from the above: In what way does your patch change the current behavior?
    • To ignore ssl verification - as the checkbox is meant to do
  • Is this a new problem? What made you submit this PR (new firmware, new device, changed device behavior)?
    • Migrating vom smstools to SMS Api

Copy link

github-actions bot commented Feb 17, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@lagrip
Copy link
Author

lagrip commented Feb 17, 2025

I have read the CLA Document and I hereby sign the CLA.

Copy link

github-actions bot commented Mar 4, 2025

Thank you for your contribution. This pull request has been marked as stale as it has not passed the automated tests and there was no activity for the last 14 days.
Please take a look at the ‘Checks’ section for details on the test results and make the necessary changes.

This pull request will be closed due to inactivity after 60 days, if no action is taken.

@github-actions github-actions bot added the Stale Scheduled for auto-close label Mar 4, 2025
@lagrip
Copy link
Author

lagrip commented Mar 4, 2025

recheck

1 similar comment
@lagrip
Copy link
Author

lagrip commented Mar 4, 2025

recheck

@lagrip
Copy link
Author

lagrip commented Mar 4, 2025

I have read the CLA Document and I hereby sign the CLA.

@lagrip
Copy link
Author

lagrip commented Mar 4, 2025

recheck

@github-actions github-actions bot removed the Stale Scheduled for auto-close label Mar 5, 2025
Copy link

Thank you for your contribution. This pull request has been marked as stale as it has not passed the automated tests and there was no activity for the last 14 days.
Please take a look at the ‘Checks’ section for details on the test results and make the necessary changes.

This pull request will be closed due to inactivity after 60 days, if no action is taken.

@github-actions github-actions bot added the Stale Scheduled for auto-close label Mar 19, 2025
@github-actions github-actions bot removed the Stale Scheduled for auto-close label May 7, 2025
Copy link

Thank you for your contribution. This pull request has been marked as stale as it has not passed the automated tests and there was no activity for the last 14 days.
Please take a look at the ‘Checks’ section for details on the test results and make the necessary changes.

This pull request will be closed due to inactivity after 60 days, if no action is taken.

@github-actions github-actions bot added the Stale Scheduled for auto-close label May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Scheduled for auto-close
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant