fix: publish empty batches to avoid staled rounds #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After we changed the 0k checker node to run all task as quickly as possible, we are hitting a deadlock where no measurements are reported towards the end of the round, and as a result, the round is never advanced. In this patch, I am changing the publisher to commit a CID for an empty file (bafkqaaa) when no measurements were recorded. Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
commented
Aug 6, 2025
pyropy
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we changed the 0k checker node to run all task as quickly as possible (see https://github.com/CheckerNetwork/spark-0k-checker/pull/26), we are hitting a deadlock where no measurements are reported towards the end of the round, and as a result, the round is never advanced.
In this patch, I am changing the publisher to commit a CID for an empty file (
bafkqaaa) when no measurements were recorded.