Fix to parse xcresulttool version when the version string has major.minor format #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inor format When testing Xcode 26 beta 2, when `xcrun xcresulttool version` is executed, the output comes in as "xcresulttool version 24038.1, schema version: 0.0.0 (legacy commands format version: 3.53)". xcresulttool() function is failing to create teh Version instance because of the unexpected format. As a result, --legacy flag is not getting added causing the parser to fail. Fix is to get the major version from version string. Tested with Xcode 26 beta 2 and beta 3 versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing Xcode 26 beta 2, when
xcrun xcresulttool versionis executed, the output comes in as "xcresulttool version 24038.1, schema version: 0.0.0 (legacy commands format version: 3.53)".We depend on xcparse to extract the logs from the xcreult file and we needed a fix for it.
Change Description:
xcresulttool() function is failing to create the Version instance because of the unexpected format. As a result, --legacy flag is not getting added causing the parser to fail.
Fix is, when the version parsing fails, get the major version from version string and drop the minor version
Test Plan/Testing Performed:
Installed xcparse with these changes, and tested with Xcode 16.4, Xcode 26 beta-2 and beta-3 versions an observed that the .xcresult file is successfully parsed in all versions.