Implement initiateMultipleValidatorExits #1764
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoeths
requested review from
dapplion,
mpetrunic and
wemeetagain
as code owners
dapplion
reviewed
Nov 18, 2020
| processOp(epochCtx, state, op, verifySignatures); | ||
| }); | ||
| }); | ||
| const indexes = readOnlyMap(body.voluntaryExits, (voluntaryExit) => voluntaryExit.message.validatorIndex); |
Contributor
There was a problem hiding this comment.
What about using
processVoluntaryExits(body.voluntaryExits, epochCtx, state)to not spread the logic in multiple files
dapplion
reviewed
Nov 18, 2020
| [body.attestations, processAttestation], | ||
| [body.deposits, processDeposit], | ||
| [body.voluntaryExits, processVoluntaryExit], | ||
| [body.voluntaryExits, verifyVoluntaryExit], |
Contributor
There was a problem hiding this comment.
I wonder if we can modify this entire statement to
processAttesterSlashings(...)
processAttestations(...)
processDeposits(...)And look for similar optimizations in the other opts
Contributor
Author
There was a problem hiding this comment.
the initiateValidatorExit() was called in slashValidator.ts also but we couldn't optimize the same way to this because it's required to process one by one there in order to use validator withdrawableEpoch correctly
other than that I don't see any similar improvement can be made so I keep other functions as is.
mpetrunic
reviewed
Nov 18, 2020
packages/lodestar-beacon-state-transition/src/fast/block/initiateValidatorExit.ts
Outdated
Show resolved
Hide resolved
twoeths
force-pushed
the
tuyen/improve-initiate-validator-exit
branch
from
9091847 to
c8f061d
Compare
Contributor
Author
|
closing this in favor of #1816 as I think the bigger issue is we loop through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1761
initiateValidatorExitfor backward reference, it's the same to the specinitiateMultipleValidatorExitswhich loop through validator array inside state only 1 timeinitiateMultipleValidatorExits