fix: use defineProperty instead of assignment #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Mistake when primordials are frozen
achingbrain
changed the title
|
Thanks for opening this. What environment are you running in where the current implementation causes a problem? |
The specific environment where we ran into this was Hardened JavaScript, but any similar high-integrity JS environment that freezes primordials will be prey to this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
returnlessSourcefunction stumbles over the infamous Javascript assignment override mistake (which is to say, it throws aTypeErrorthat it very much should not be throwing) if running in a locked down environment where the primordials are frozen. The fix is to usedefinePropertyinstead of direct assignment in the sensitive property updates.