fix: handle zero port values in ENR field display#48
Merged
nflaig merged 1 commit intoChainSafe:masterfrom Mar 19, 2026
Merged
Conversation
ENR records can have port values of 0 (tcp, udp, tcp6, etc.) when a node is not listening on that transport. The previous check used `!field` which treats 0 as falsy, throwing 'Field not found' and crashing the viewer. Use `field == null` to only throw on truly missing fields (undefined/null), correctly displaying port 0 as a valid value. Co-authored-by: lodekeeper <lodekeeper@users.noreply.github.com>
nflaig
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ENR records can have port values of
0(tcp, udp, tcp6, etc.) when a node is not listening on that transport. The viewer crashes when decoding these records because the check:treats
0as falsy and throws.Repro: paste this ENR into the viewer:
This ENR has
tcp: 0,tcp6: 0,udp6: 0— all valid, meaning the node doesn't listen on those transports.Fix
Use
field == nullinstead of!fieldto only throw on truly missing fields (undefined/null), correctly displaying port0as a valid value.Note
This PR was authored with AI assistance (Lodekeeper 🌟).