fix(reconciler): index missing for token updates#175
Open
dhyaniarun1993 wants to merge 4 commits intomainfrom
Open
fix(reconciler): index missing for token updates#175dhyaniarun1993 wants to merge 4 commits intomainfrom
dhyaniarun1993 wants to merge 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new database migration that adds unique indexes to the user_token_balances table to support upsert operations. The feedback suggests refactoring both the up and down migration logic to utilize the bun ORM's schema builder instead of raw SQL strings, which would improve maintainability and ensure consistency with idiomatic Go practices when using this library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Migration 10_create_user_token_balances.go only calls CreateSchema, which creates the table but no unique indexes. Three ON CONFLICT clauses in pg.go require unique constraints that don't exist in the DB
Solution
Add the indexes in migration