Generate solc cache key from versions #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certora Run Started (Fail to Start)
Certora Run Summary
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Solidity compiler binary caching mechanism by incorporating Solc version hashes into the cache key generation. This ensures that the cache is properly invalidated when Solc versions change, while maintaining backward compatibility through restore keys.
- Generates a hash-based cache key from the Solc versions input to ensure cache refreshes on version changes
- Adds conditional caching logic that only applies when Solc versions are specified
- Implements restore keys for backward compatibility with existing cache entries
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![certora-run[bot]](https://avatars.githubusercontent.com/in/1083145?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verification Results
- Group ID: 34521df0-ec2c-4473-af65-87169afd864b
| Job | Result | SANITY_FAILED | VIOLATED | Link |
|---|---|---|---|---|
| Default.conf | ❌ | 2 | 1 | Link |
fnast9
approved these changes
Aug 28, 2025
Certora Run Started (Fail to Start)
Certora Run Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request Overview
This PR adds a hash of Solc versions for the cache key generation and adds restore keys for backward compatibility. This change helps with refreshing the cache on Solc version changes.
📜 Tests Checklist
Before submitting this PR, ensure that all tests pass and meet the following conditions: