Edit curl settings #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR unifies curl command settings across GitHub API calls to improve reliability and avoid common network issues. The changes add consistent timeout, retry, and error handling flags to all curl commands that interact with GitHub APIs.
- Adds
--retry 3and--max-time 30flags to provide consistent retry behavior and timeout settings - Standardizes curl flags with
-sSfLfor silent operation, fail-fast behavior, and location following - Applies changes across shell scripts and GitHub Action configurations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/solc-download.sh | Updates curl commands for Solidity compiler downloads with standardized retry and timeout settings |
| scripts/gh-app-integration.sh | Applies unified curl settings to GitHub OIDC token fetching and API verification calls |
| action.yml | Updates curl command in GitHub Action workflow with consistent timeout and retry configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Certora Run Started (Fail to Start)
Certora Run Summary
|
Co-authored-by: Copilot <[email protected]>
Certora Run Started (Fail to Start)
Certora Run Summary
|
yoav-el-certora
approved these changes
Aug 28, 2025
![certora-run[bot]](https://avatars.githubusercontent.com/in/1083145?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verification Results
- Group ID: 8c1b8c94-099a-4803-8d76-33df49e8e4c6
| Job | Result | SANITY_FAILED | VIOLATED | Link |
|---|---|---|---|---|
| Default.conf | ❌ | 2 | 1 | Link |
Certora Run Started (Fail to Start)
Certora Run Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request Overview
This PR unifies curl settings to avoid common network issues when using GH APIs.
📜 Tests Checklist
Before submitting this PR, ensure that all tests pass and meet the following conditions: