-
Notifications
You must be signed in to change notification settings - Fork 43
Niv/fix sanity failure #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cli-beta
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits and questions - looks ok for me.
// invariant version is getting SANITY_FAILURE using the below rule instead | ||
// invariant lockStatusDontChange() | ||
// !contract_lock_status; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which sanity failure did you receive on this invariant?
I couldn't find a link to a failing job here:
https://certora.atlassian.net/browse/CERT-9252
@@ -129,12 +129,6 @@ hook Sstore _customers[KEY address user].accounts.length uint256 newLength { | |||
numOfAccounts[user] = newLength; | |||
} | |||
|
|||
/** | |||
An internal step check to verify that our ghost works as expected, it should mirror the number of accounts. | |||
Once the sload is defined, this invariant becomes a tautology |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the sload is defined, this invariant becomes a tautology
Is sload now defined nowadays, so is this why we see the sanity failure for trivial post condition of the invariant?
CERT-9252 | Fix sanity failures in induction base for major version 8
No description provided.