Niv/fix sanity failure #183
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivcertora
requested review from
nd-certora and
yoav-el-certora
and removed request for
liav-certora
johspaeth
reviewed
Jul 7, 2025
Comment on lines
+23
to
+25
| // invariant version is getting SANITY_FAILURE using the below rule instead | ||
| // invariant lockStatusDontChange() | ||
| // !contract_lock_status; |
There was a problem hiding this comment.
Which sanity failure did you receive on this invariant?
I couldn't find a link to a failing job here:
https://certora.atlassian.net/browse/CERT-9252
| @@ -129,12 +129,6 @@ hook Sstore _customers[KEY address user].accounts.length uint256 newLength { | |||
| numOfAccounts[user] = newLength; | |||
| } | |||
|
|
|||
| /** | |||
| An internal step check to verify that our ghost works as expected, it should mirror the number of accounts. | |||
| Once the sload is defined, this invariant becomes a tautology | |||
There was a problem hiding this comment.
Once the sload is defined, this invariant becomes a tautology
Is sload now defined nowadays, so is this why we see the sanity failure for trivial post condition of the invariant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.