Split up form models into individual files#236
Merged
Conversation
Tests as well. Should be otherwise equivalent
XanderVertegaal
approved these changes
Apr 28, 2026
Contributor
XanderVertegaal
left a comment
XanderVertegaal
left a comment
There was a problem hiding this comment.
Great, much cleaner :)
| from django.db import models | ||
|
|
||
|
|
||
| # Questions |
Contributor
There was a problem hiding this comment.
These comments that are now at the top of each file were meant to give structure to our old monolithic models.py. As far as I am concerned, these can go now, but I'll leave that up to you :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did this at the start of my new feature but you guys are developing way too fast, causing me to have to de a lengthy rebase rather often. Hope you all agree this tidies up the
models.pysituation :)Form tests get the same treatment. Should be functionally equivalent.