feature: selectoptions can now be ordered.#216
feature: selectoptions can now be ordered.#216RoordinkFrank wants to merge 4 commits intodevelopfrom
Conversation
|
I did just now notice load_fixtures does not work anymore. I am not sure if load_fixtures should be changed or the select option. Is is supposed to be nullable? I don´t think so? |
XanderVertegaal
left a comment
XanderVertegaal
left a comment
There was a problem hiding this comment.
Works well!
As you mentioned, some parts of the code that are now duplicated (conversion of str -> list[int], making sure that all IDs exist) could be outfactored to reusable functions to make things a bit more DRY, but you may leave that for another PR if desired.
|
|
||
|
|
||
| class SelectQuestionAdminForm(ModelForm): | ||
| options_order = CharField( |
There was a problem hiding this comment.
I prefer option_order, to keep things in line with substep_order and question_order. Make sure to also change this in admin.py.
|
|
||
| # Validate that the provided IDs exist. | ||
| available_ids = [question.id for question in self.instance.options.all()] | ||
| # In instance.NAME.all(), NAME is the verbose name. |
There was a problem hiding this comment.
This comment belongs to the line above it. I also think you mean related name when you say verbose name (which is something else).
2 participants
fixes #174
Forms.py is slowly getting more duplicate code. I don´t think this can be easily changed but perhaps something to look into after the MVP.