Skip to content

Keep selection of assessment form selection#92

Merged
XanderVertegaal merged 4 commits intodevelopfrom
bugfix/assessment-form-selection
Apr 13, 2026
Merged

Keep selection of assessment form selection#92
XanderVertegaal merged 4 commits intodevelopfrom
bugfix/assessment-form-selection

Conversation

@tijmenbaarda
Copy link
Copy Markdown
Contributor

Close #51. Please look at it critically, I'm not sure if this is the most idiomatic solution.

Copy link
Copy Markdown
Contributor

@XanderVertegaal XanderVertegaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally your change works (and actually requires very little code <3), but it does mix reactive form syntax with template-driven form syntax (with ngModel).

I played around with it a little bit and in the end decided to just get rid of the whole CONTROL_VALUE_ACCESSOR thing. It reduces the amount of code and allows us to simply use the control on the select element directly and use [ngValue], as per the docs.

What do you think?

Copy link
Copy Markdown
Contributor

@XanderVertegaal XanderVertegaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other news: develop was throwing errors about missing animations. Apparently this is is caused by my last PR (Matomo) which ripped out the deprecated animations module. I've pushed a commit that migrates the animations to native CSS animations.

@XanderVertegaal XanderVertegaal merged commit 40d1ca5 into develop Apr 13, 2026
1 check passed
@XanderVertegaal XanderVertegaal deleted the bugfix/assessment-form-selection branch April 13, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assessment form dropdown selection jumps back

2 participants