[ENG-8627] | Fix .3ds files not rendering in MFR viewer #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opaduchak
requested changes
Aug 20, 2025
Comment on lines
583
to
585
| var materialFaces = this._cur_obj.materialFaces || {}; | ||
| var sawMaterial = false; | ||
| for (var materialName in materialFaces) { |
There was a problem hiding this comment.
Nit: It's better to use let instead of var
|
|
||
| var currentMaterial = this._materials[materialName]; | ||
| if (!currentMaterial) { | ||
| if (JSC3D.console) JSC3D.console.logWarning('3DS: missing material "' + materialName + '", using defaults.'); |
There was a problem hiding this comment.
please don't use oneline if statements
Suggested change
| if (JSC3D.console) JSC3D.console.logWarning('3DS: missing material "' + materialName + '", using defaults.'); | |
| if (JSC3D.console) { | |
| JSC3D.console.logWarning('3DS: missing material "' + materialName + '", using defaults.'); | |
| } |
opaduchak
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Changes
Side effects
QA Notes
Deployment Notes