[ENG-8501] Upgrade tornado version to "6.5.1" #398
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all pre-commit install installation is needed)
update ruff configs to be it similar with previously used flake8
…re fixes than ruff format . add B904 for ruff ignore maybe if we do some actions to update codestyle it may change business logic
cslzchen
changed the title
cslzchen
requested changes
Aug 7, 2025
cslzchen
reviewed
Aug 7, 2025
Comment on lines
-46
to
+47
| waterbutler = { git = "https://github.com/CenterForOpenScience/waterbutler.git", branch = "feature/buff-worms" } | ||
| #waterbutler = { git = "https://github.com/CenterForOpenScience/waterbutler.git", branch = feature/buff-worms" } | ||
| waterbutler = { git = "https://github.com/Vlad0n20/waterbutler.git", branch = "feature/ENG-8500" } |
There was a problem hiding this comment.
In addition, let's don't change this for now since the WB PR will be merged before this one.
|
close because will move ruff for post release updates for tornado there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-8501
Purpose
Summary
When Tornado's multipart/form-data parser encounters certain errors, it logs a warning but continues trying to parse the remainder of the data. This allows remote attackers to generate an extremely high volume of logs, constituting a DoS attack. This DoS is compounded by the fact that the logging subsystem is synchronous.
Affected versions
All versions of Tornado prior to 6.5 are affected. The vulnerable parser is enabled by default.
Changes
Upgrade to Tornado version 6.5. In the meantime, risk can be mitigated by blocking Content-Type: multipart/form-data in a proxy. It looks like there is no breaking changings in backlog https://www.tornadoweb.org/en/stable/releases/v6.5.0.html , so no code changings is needed.
added the changing to the PR #395 to keep it changings .
Side effects
MFR rely on waterbutler so WB merging is needed to be done first of all to keep system consistent, am going to update back to #waterbutler = { git = "https://github.com/CenterForOpenScience/waterbutler.git", branch = feature/buff-worms" } after the updates CenterForOpenScience/waterbutler#461 will be merged
QA Notes
FYI:
I see that Tornado has 6.5.1 version already that looks to be more stable with non latin chars (locally it goes ok with testing such a chars for 6.5.0 but there is many of them so maybe it is better to migrate to 6.5.1)?
Deployment Notes