Skip to content

[ENG-8472] Files with Cyrillic in their names won't render #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025
Merged

[ENG-8472] Files with Cyrillic in their names won't render #392

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96ece99
fixed files with cyrillic names not rendering
opaduchak Jul 26, 2025
d3cd6e4
made content-dispositon header use modern filename* syntax
opaduchak Jul 28, 2025
46f5c3b
fixed filename=* syntax
opaduchak Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mfr/server/handlers/export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import asyncio
import logging
import os
from urllib.parse import quote

from waterbutler.core.exceptions import InvalidParameters, DownloadError
import waterbutler.core.streams
Expand Down Expand Up @@ -118,6 +119,6 @@ async def _cache_and_clean(self):
pass

def _set_headers(self):
self.set_header('Content-Disposition', 'attachment;filename="{}"'.format('{}.{}'.format(self.metadata.name.replace('"', '\\"'), self.format)))
self.set_header('Content-Disposition', f'attachment;filename="{quote(self.metadata.name.replace('"', '\\"'))}.{self.format}"')
if self.metadata.content_type:
self.set_header('Content-Type', self.metadata.content_type)