Skip to content

PAINTROID-793 implement watercolor tool #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Amit-Matth
Copy link
Contributor

@Amit-Matth Amit-Matth commented Jul 5, 2025

Introduced Watercolor Tool with improved stroke rendering.

PAINTROID-793

New Features and Enhancements

  • Added the Watercolor Tool with soft, brush-like stroke effects using blur.
  • Integrated Watercolor Tool into the toolbox and stroke options UI.
  • Implemented proper undo/redo support for watercolor strokes.
  • Added unit and integration tests to verify tool behavior and rendering.

Refactorings and Bug Fixes

  • Improved tap/dot drawing behavior for path-based tools.
  • Updated CommandManager to better identify watercolor commands.
  • Ensured accurate rendering and caching of paths while drawing.

Checklist

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Add the link to the ticket in Jira in the description of the PR
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines (Wiki)
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Add new information to the Wiki

@bakicelebi
Copy link
Contributor

Saving a water colored projects has bugs. It shows the drawn lines as full opaque brush lines.
image

@bakicelebi
Copy link
Contributor

I also get this error on iOS simulator:

[ERROR:flutter/impeller/entity/contents/contents.cc(122)] Break on 'ImpellerValidationBreak' to inspect point of failure: Contents::SetInheritedOpacity should never be called when Contents::CanAcceptOpacity returns false.

This is probably an easy fix.

@Amit-Matth
Copy link
Contributor Author

I fixed the bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants