Skip to content

PAINTROID-764 add more shapes and styles #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Amit-Matth
Copy link
Contributor

@Amit-Matth Amit-Matth commented Jun 16, 2025

PAINTROID-764

This pull request introduces several enhancements to the Shapes tool, including new shapes, advanced styling options, and improved resizing capabilities.

New Features and Enhancements

  • Added New Shapes:
    • Introduced the Star shape, allowing users to create multi-pointed stars.
    • Added the Heart shape for creating heart figures.
  • Enhanced Existing Shapes:
    • Upgraded the previous Circle shape to a more versatile Oval shape, enabling independent control over width and height.
  • Improved Shape Manipulation:
    • Implemented Edge Resizing for shapes within the bounding box, allowing users to intuitively scale shapes by dragging their top, bottom, left, or right edges. This complements existing corner resizing.
  • Expanded Shape Styling Options:
    • Added Dashed style for shape outlines.
    • Added Filled style to fill shapes with the selected color.
    • Added FillAndDashed style, combining a filled interior with a dashed outline.

Refactorings and Bug Fixes

  • Made rotation arc handle interactions more intuitive through improved hit detection and a refined user feedback model.
  • Corrected shape padding calculations to ensure consistent visual results across different stroke widths and styles.

Checklist

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Add the link to the ticket in Jira in the description of the PR
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines (Wiki)
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Add new information to the Wiki

@bakicelebi
Copy link
Contributor

bakicelebi commented Jun 27, 2025

Hi Amit,

Please for future tickets stay in the scope of the ticket! Changing the bounding box was not the requirement of this ticket.

@bakicelebi bakicelebi closed this Jun 27, 2025
@bakicelebi bakicelebi reopened this Jun 27, 2025
@bakicelebi
Copy link
Contributor

image

Please position the carousel views in a column and adjust the styling of the new carousel. Also remove the padding on the left and right so that its flush with the screen.

@bakicelebi
Copy link
Contributor

Resizing the rectangle from an edge still scales it visibly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants