fix(security): preserve pinned authority across CodeQL history pages - #122
Merged
Merged
Conversation
Owner
Author
|
Post-merge verification complete for actual main f1b21eb: all 52 checks / 8 triggered workflows passed, with no failed, pending or skipped checks.
This closes the pre-merge body’s remaining main-verification step. It does not complete D2 installation, D3 team deployment, D4 real-user/scientific validation or a new release. Old failure records remain preserved; no scientific-breakthrough or mass-readiness claim is made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the real
invalid_paginationfailure in main Safe Product run 34542239525, observed after #121 merged the Brain preview and README.GitHub's multi-page main analysis history uses numeric repository-ID Link paths. The adapter now treats those links only as page-transition hints and reconstructs every request on the original named repository endpoint. Origin, endpoint, immutable filters, duplicate keys, forward progress, caps, deadlines, redirect protection and later blocking alerts remain enforced. No scanner suppression, alert dismissal, first-page-only shortcut or permission change.
Reviewed feature:
e5dafe3fcc25bdef087dca2d2f6240e5f146fd49; source fixfb269290278facadbb8773ab64a01145a2e59693, then official artifact-only refresh. Actual tested merge:77c7422361623d5d0d4568f91a9fca98781f5e3b, with exactly mainf8e0a16and featuree5dafe3as parents; its tree equals the reviewed local tree.Validation
python scripts/verify_brain_d1.py --expected-source-sha e5dafe3fcc25bdef087dca2d2f6240e5f146fd49 --output <fresh-evidence>— 1941 passed, 16 explicit optional skips, 694.50s. All427 Brain/native13/F01–F14 pass, clean exact source. Windows/Python3.13.2. D1 evidence SHA2567800362639ee4bd41905ae05b790484ee2144362148921fa0022d3997f742731.6f817759698a6f0537978b3f7058e776e9829c2d9ec14e9105bf43a34c7f207b; clean1587-file before/after manifest010d5460e249f233ae03057422f59fd5f27b6238bda6835a7dc7976fe508fe30. No unexpected or Brain skips.ae26db9bd507dc5f51c54dd8d45254d53bac958042d4755d0a88182d136862ea; SafeProductf4a515fd401157b3baad2c59811ad95c7db90e977038876376c94161948d49c4; evaluation64c2121e068121a20e7340bc0daa0da1b905aa749282573eace315482efeeea6.Evidence And Release Impact
Only the adapter, regression tests and five established generated evidence files change. Generated differences are timestamps/source bindings and dependent digests; checked-in local admission remains15/16 blocked without hosted prerequisites. No Brain runtime, token issuance, README, workflow, dependency, version or benchmark outcome change.
PR success is not post-merge main success: verify the new main run separately, including the full paginated history that originally failed. The original failed main run remains preserved.
No release/tag/PyPI publication. D1 remains a Python-based plaintext preview for nonsecret material; D2 installation, D3 team deployment, D4 measured usefulness and scientific novelty are unfinished. Engineering and measurement-validity admission do not establish a scientific breakthrough or mass usefulness.
Checklist