Skip to content

Conversation

@joeyshuttleworth
Copy link
Collaborator

Description

The "passed_wells.txt" file outputted didn't account for QC.R_leftover, so these values would have to be checked manually. Now passed_wells only contains those wells which pass QC.R_leftover for the QC/staircase protocols (args.D2SQC).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

Documentation checklist

  • I have updated all documentation in the code where necessary.
  • I have checked spelling in all (new) comments and documentation.
  • I have added a note to RELEASE.md if relevant (new feature, breaking change, or notable bug fix).

@joeyshuttleworth
Copy link
Collaborator Author

Spotted a bug here. don't merge

@mirams mirams marked this pull request as draft November 4, 2025 15:45
@joeyshuttleworth joeyshuttleworth marked this pull request as ready for review November 7, 2025 11:36
@joeyshuttleworth joeyshuttleworth merged commit 0f31894 into main Nov 7, 2025
11 checks passed
@joeyshuttleworth joeyshuttleworth deleted the js_fix_passed_wells branch November 7, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants