Skip to content

Apply QC1 and QC4 to multiple sweeps #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MichaelClerx wants to merge 98 commits into from
Closed

Apply QC1 and QC4 to multiple sweeps #107

MichaelClerx wants to merge 98 commits into from

Conversation

@MichaelClerx
Copy link
Member

@MichaelClerx MichaelClerx commented Nov 11, 2025

js_multiple_qc1_4 was for applying QC1 and QC4 to both sweeps of the staircase protocol. It involved rewriting the hERGQC class a little bit. I think we want to leave that out for now.

Joseph G. Shuttleworth and others added 30 commits October 29, 2025 13:33
Save plot during test. Use different data. Remove unnecessary variable
cee26d1
Fix test leak plot output
60e779b
Use after-drug data for test_subtraction_plot
0a25314
Remove unused import
5a01d93
Plot corrected trace with solid line not dashed - fixes legend
d99d15d
Merge pull request #85 from CardiacModelling/fix_test_sub_plots
9d98f80 
Fix plots in test scripts
Fix gleak, Eleak calculation in subtraction plot
4d676f8
Fix Eleak, gleak calculation in do_subtraction_plot
65eb28d
Remove unused variables
3eba019
Merge branch 'main' into js_fix_subtraction_plots
9a3cd9e
Correct labelling of gleak and Eleak
df7deb7
Merge pull request #86 from CardiacModelling/js_fix_subtraction_plots
e634398 
Fix corrected leak plotting on subtraction plots
@frankiepe
Make default plotsize bigger
a72885d
@mirams
Merge pull request #87 from CardiacModelling/bigger_plots
dd14ca4 
Make default plotsize bigger
Whitespace fix
31a1e5a
@mirams
Show more detail, smaller V
2367770
@mirams
Linting
2183087
@mirams
Tidy up
c122fab
@mirams
Tidy Vcmd fontsize in panel a
8a889ab
@frankiepe
Use the correctly indexed current sweep for leak correction
a870c4b
@frankiepe
Merge pull request #88 from CardiacModelling/subtraction_enhancements
dd0b547 
Subtraction plot enhancements
@frankiepe
Merge branch 'main' into leak_correct_bugfix
114e168
@frankiepe
Merge pull request #89 from CardiacModelling/leak_correct_bugfix
af48221 
Use the correctly indexed current sweep for leak correction
Simplify subtraction plot code
069431e
Fix formatting
ae6e5db
Remove unused vars
f70fa00
@frankiepe
Make default plotsize bigger
d201ffc
Show more detail, smaller V
9373331
@mirams
Linting
581c5e1
Tidy up
3b1cf89
Joseph G. Shuttleworth and others added 28 commits November 6, 2025 11:55
Add test for reversal inference
e26b206
Fix test infer reversal
63fcb98
Merge branch 'js_fix_infer_reversal' of github.com:CardiacModelling/p…
7f919d5 
…cpostprocess into js_fix_infer_reversal
Update test
ccae122
Update test
93d4ca4
Modify test
72cd27a
@joeyshuttleworth
Merge pull request #100 from CardiacModelling/js_fix_infer_reversal
3053872 
Fix reversal potential inference and docstring for detect_ramp_bounds
@joeyshuttleworth
Merge branch 'main' into js_fix_passed_wells
e298a70
@joeyshuttleworth
Merge pull request #93 from CardiacModelling/js_fix_passed_wells
0f31894 
Account for "QC_R_leftover" in passed_wells
Fix QC bug
7e827d8
Merge branch 'js_fix_passed_wells'
87cad31
@joeyshuttleworth
Revert "Account for "QC_R_leftover" in passed_wells"
9af8af1
Fix QC.R_leftover bug
e5ec8a1
@MichaelClerx
Merge pull request #102 from CardiacModelling/revert-93-js_fix_passed…
46c738d 
…_wells

Fix bug in QC.R_leftover
@MichaelClerx
Removed unused init file
26a436b
@MichaelClerx
Removed wrong comment in github workflow
d7ba22e
@MichaelClerx
Merge pull request #103 from CardiacModelling/last-old-version
62a0bd5 
Last old version
@MichaelClerx
Adding changelog and contributing.md
29fd77b
@MichaelClerx
Updated changelog and readme
653d749
@MichaelClerx
Updated year in license file
83265eb
@MichaelClerx
Fixed links in CONTRIBUTING.md
bd46b8f
@MichaelClerx
Updated CONTRIBUTING.md
ac6a3b8
@MichaelClerx
Updated links in CONTRIBUTING.md
bbd5b0a
@MichaelClerx
Fixed link to license file in readme
ede1f78
@MichaelClerx
Fixed link to license file in readme, again
33196f1
@MichaelClerx
Trying out short links in contributing.md
ad464de
@MichaelClerx
Updated links in CONTRIBUTING.md
3226510
@MichaelClerx
Merge pull request #104 from CardiacModelling/contrib-changelog
eeb6f11 
Add changelog and a provisional contributing.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MichaelClerx @frankiepe @mirams @joeyshuttleworth