Skip to content

Fix bug in QC.R_leftover #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelClerx merged 4 commits into from
Nov 11, 2025
Merged

Fix bug in QC.R_leftover #102

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e827d8
Fix QC bug
Nov 7, 2025
87cad31
Merge branch 'js_fix_passed_wells'
Nov 7, 2025
9af8af1
Revert "Account for "QC_R_leftover" in passed_wells"
joeyshuttleworth Nov 7, 2025
e5ec8a1
Fix QC.R_leftover bug
Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pcpostprocess/scripts/run_herg_qc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ def main():

# R_leftover only considered for protocols used for QC (i.e. staircase protocols)
passed_QC_R_leftover = np.all(sub_df[sub_df.protocol.isin(args.D2SQC.values())]
["R_leftover"].values
["QC.R_leftover"].values
)

logging.info(f"passed_QC_R_leftover {passed_QC_R_leftover}")
Expand All @@ -332,9 +332,9 @@ def main():
was_selected = np.all(sub_df['selected'].values)

passed_qc = passed_qc3_bookend and was_selected\
and passed_QC_Erev_all and passed_QC1_all\
and passed_QC_Erev_spread and passed_QC4_all\
and passed_QC6_all and passed_QC_R_leftover
and passed_QC_Erev_all and passed_QC6_all\
and passed_QC_Erev_spread and passed_QC1_all\
and passed_QC4_all

passed_qc_dict[well] = passed_qc

Expand Down