Skip to content

Conversation

@MichaelClerx
Copy link
Member

@MichaelClerx MichaelClerx commented Nov 6, 2025

Start on #117

Separates command line argument parsing and export_config from code in run_herg_qc

@MichaelClerx MichaelClerx marked this pull request as ready for review November 11, 2025 14:38
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 0% with 105 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.79%. Comparing base (36d3eac) to head (e7125e8).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
pcpostprocess/scripts/run_herg_qc.py 0.00% 104 Missing ⚠️
pcpostprocess/scripts/__main__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #101       +/-   ##
===========================================
- Coverage   91.73%   37.79%   -53.94%     
===========================================
  Files          11       14        +3     
  Lines         871     2114     +1243     
===========================================
  Hits          799      799               
- Misses         72     1315     +1243     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MichaelClerx
Copy link
Member Author

Verified current code produces same output as original for run_herg_qc.py

@MichaelClerx MichaelClerx merged commit 60e55ff into main Nov 12, 2025
6 of 8 checks passed
@MichaelClerx MichaelClerx deleted the coverage branch November 12, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants