Skip to content

Conversation

@joeyshuttleworth
Copy link
Collaborator

@joeyshuttleworth joeyshuttleworth commented Nov 6, 2025

Description

Fix reversal potential inference due to a mismatch in what is returned from detect_ramp_bounds. Update/correct detect_ramp_bounds docstring and variable/parameter names. Closes #99.

Includes new test for infer_reversal_potential().

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

Documentation checklist

  • I have updated all documentation in the code where necessary.
  • I have checked spelling in all (new) comments and documentation.
  • I have added a note to RELEASE.md if relevant (new feature, breaking change, or notable bug fix).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameter name was a bit confusing here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines were causing infer reversal potential to fail for every single trace

@joeyshuttleworth joeyshuttleworth merged commit 3053872 into main Nov 7, 2025
6 checks passed
@joeyshuttleworth joeyshuttleworth deleted the js_fix_infer_reversal branch November 7, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reversal potential inference fails

3 participants