You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
This major upgrade breaks the repository's npm run zip path. I tested the exact commits after a successful build: the base (7822e235, locked archiver@7.0.1) prints Extension zip created and exits 0, while this PR (4b8892fc, locked archiver@8.0.0) fails at const archive = archiver(...) with TypeError: archiver is not a function, exits 1, and leaves a 0-byte extension.zip. Archiver 8 exposes the ESM/default export differently, but create-extension-zip.js still uses const archiver = require('archiver'). Please migrate the packaging script to the v8 export/API (and avoid leaving the empty output on failure), or keep v7.
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot was not present on this PR. This major archiver v8 bump may break the CommonJS create-extension-zip.js packaging path, so human review is required before merge. Reviewers assigned.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot was not present on this PR. The archiver v8 major bump is ESM-only and may break the CommonJS create-extension-zip.js packaging path, so human review is required before merge. Reviewers are already assigned.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Risk: medium. Cursor Bugbot was not present on this PR. The archiver v8 major bump may break the CommonJS create-extension-zip.js packaging path, so human review is required before merge. Reviewers are already assigned.
Sent by Cursor Approval Agent: Pull Request Approver External
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jinhongliang991013
left a comment
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This PR contains the following updates:
^7.0.1→^8.0.0Release Notes
archiverjs/node-archiver (archiver)
v8.0.0Compare Source
What’s changed
Breaking changes
Maintenance
Documentation
Dependency updates
Configuration
📅 Schedule: (UTC)
* 0-3 * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.