Skip to content

feat: add feature flags ETag caching - #1129

Merged
greatest0fallt1me merged 1 commit into
CalloraOrg:mainfrom
Baskarayelu:fix/feature-flags-etag-1103
Jul 30, 2026
Merged

feat: add feature flags ETag caching#1129
greatest0fallt1me merged 1 commit into
CalloraOrg:mainfrom
Baskarayelu:fix/feature-flags-etag-1103

Conversation

@Baskarayelu

Copy link
Copy Markdown
Contributor

Summary

  • add strong ETags to GET /api/feature-flags using stable flag data
  • honor If-None-Match with 304 responses while keeping request metadata out of the validator
  • return 200 for stale tags and preserve injectable rate-limit behavior

Verification

  • npx jest src/routes/feature-flags.test.ts --runInBand --forceExit (8 tests passed)

Note

The upstream route referenced a missing config.featureFlagsRateLimit; this PR falls back to the existing REST rate-limit configuration unless a route-specific middleware is injected.

Closes #1103

@greatest0fallt1me
greatest0fallt1me merged commit cd54946 into CalloraOrg:main Jul 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ETag / 304 caching on /api/feature-flags [b#041]

2 participants