This repository was archived by the owner on Sep 7, 2020. It is now read-only.
Open
Conversation
Member
Author
|
Another approach I'd be okay with is just using the offline indicator (maybe changing the copy or color) |
knrafto
reviewed
Mar 18, 2017
Member
knrafto
left a comment
knrafto
left a comment
There was a problem hiding this comment.
Can you deploy to staging? I have a feeling it won't be shown for that long (I.e. I think most of the loading time is HTML/JS)
| } | ||
|
|
||
| /* Loading Spinner */ | ||
| .spinner { |
Member
Author
|
It's up: http://officehours-web-staging.app.cs61a.org/ it is not up for very long - but there is movement. I think something that might be better would just displaying the OH favicon center aligned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a noticeable delay when using oh.cs61a.org before the page renders - this is a temporary attempt at a loading page
it looks like this:
I'm open to using any of the spinners here: http://tobiasahlin.com/spinkit/