[1.21.4] Fix crash with level wrappers#616
Merged
2No2Name merged 1 commit intoCaffeineMC:developfrom Jan 19, 2025
IThundxr:pr/level-fix
Merged
[1.21.4] Fix crash with level wrappers#6162No2Name merged 1 commit intoCaffeineMC:developfrom IThundxr:pr/level-fix
2No2Name merged 1 commit intoCaffeineMC:developfrom
IThundxr:pr/level-fix
Conversation
Contributor
IThundxr
commented
Jan 19, 2025
IThundxr
commented
- Use the passed RegistryAccess instead of retrieving it from the level ourselves, this fixes an issue with mods like create that wrap levels, as this mixin injects into the super call, and they set the level after the super call, which results in their stored/wrapped level being null when Level#registryAccess is called
- Use the passed RegistryAccess instead of retrieving it from the level ourselves, this fixes an issue with mods like create that wrap levels, as this mixin injects into the super call, and they set the level after the super call, which results in their stored/wrapped level being null when Level#registryAccess is called
IThundxr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.