Skip to content

Use upstream method to get global addrespace (NFC) #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2025
Merged

Use upstream method to get global addrespace (NFC) #770

merged 2 commits into from
Jul 21, 2025

Conversation

veselypeta
Copy link

Removes DataLayout::getGlobalsAddressSpace and prefer the upstream equivalent DataLayout::getDefaultGlobalsAddressSpace().

arichardson
arichardson reviewed Jul 1, 2025
View reviewed changes
arichardson
arichardson approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these should probably be using checks on the ABI instead but as an initial cleanup patch this LGTM. Thanks!

@arichardson
Copy link
Member

@jrtc27 are you happy with this?

jrtc27
jrtc27 reviewed Jul 16, 2025
View reviewed changes
@arichardson arichardson merged commit 5869c66 into CTSRD-CHERI:dev Jul 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrtc27 jrtc27 jrtc27 left review comments

@arichardson arichardson arichardson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veselypeta @arichardson @jrtc27