Open
Conversation
added 5 commits
October 17, 2017 09:34
1 produce an intermediate file using the current code 2 save the file in test_files 3 switch of saving the reference file 4 from now on test if the code still reproduces the reference fiel 5 optimize the code but keep running the test in between to test if the resutls stay the same. some optimization almost everywhere the outputfile is opened again and again in the inner loop, although it is already open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
here are some of my suggestion, please have a look at the comments and commit messages.
it's probably best to merge this in a separate branch for testing before merging into master.