Skip to content

fix: handle queryables ecmwf properties for not-ecmwf federation backends - #132

Open
anesson-cs wants to merge 1 commit into
mainfrom
cop-ghsl-queryables
Open

fix: handle queryables ecmwf properties for not-ecmwf federation backends#132
anesson-cs wants to merge 1 commit into
mainfrom
cop-ghsl-queryables

Conversation

@anesson-cs

@anesson-cs anesson-cs commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

When an ECMWF property was returned as a queryable of a federation backend not having the ECMWFSearch plugin, it was still the same as if it was for an ECMWF federation backend.

For instance, the request /collections/GHS_SMOD/queryables?provider=cop_ghsl returned ecmwf:year instead of year in queryables properties.

This issue is fixed now with corresponding tests.

However, a thinking may be done about the necessity to add this level of complexity on the server to handle queryables in general.

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Test Results

  4 files  ±0    4 suites  ±0   1m 32s ⏱️ +5s
117 tests +1  117 ✅ +1  0 💤 ±0  0 ❌ ±0 
468 runs  +4  468 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 1ccf6b3. ± Comparison against base commit b430e8e.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

badge

Code Coverage

Details
Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------
eodag/__init__.py                            0       0  100.00%
eodag/app.py                                73      15  79.45%   122, 136-143, 154-156, 212-224, 228
eodag/client.py                             24       0  100.00%
eodag/config.py                             19       0  100.00%
eodag/constants.py                           5       0  100.00%
eodag/core.py                              318      27  91.51%   136-137, 147, 293-294, 384, 518-519, 538, 581, 668, 684-688, 702-706, 708-712, 717, 730, 740-742, 745-746, 756, 759, 775
eodag/cql_evaluate.py                       48      18  62.50%   48, 53, 58, 75, 78, 81, 86-99, 105
eodag/dag.py                                57       0  100.00%
eodag/errors.py                             94       7  92.55%   145, 162-165, 181, 205
eodag/logs.py                               62       9  85.48%   40-49, 105
eodag/middlewares.py                        32       2  93.75%   20, 24
eodag/telemetry.py                          44       0  100.00%
eodag/utils.py                              41      10  75.61%   44, 69, 72-73, 86, 90-98, 134
eodag/eodag_types/__init__.py                0       0  100.00%
eodag/eodag_types/queryables.py             42       8  80.95%   46, 50-51, 61, 77-81
eodag/eodag_types/search.py                 25      25  0.00%    20-69
eodag/extensions/collection_order.py        71       1  98.59%   102
eodag/extensions/data_download.py          121      42  65.29%   61-73, 94, 112-113, 120, 135-142, 147-148, 155-187, 195-198
eodag/extensions/filter.py                 127       9  92.91%   190-191, 361-362, 382, 390, 396, 414-416
eodag/extensions/offset_pagination.py       12       0  100.00%
eodag/models/__init__.py                     0       0  100.00%
eodag/models/item.py                        78       6  92.31%   47-50, 52, 64
eodag/models/links.py                      148      13  91.22%   39, 93-95, 201, 219, 251, 299, 348-359
eodag/models/stac_metadata.py                5       0  100.00%
TOTAL                                     1446     192  86.72%

Diff against main

Filename                      Stmts    Miss  Cover
--------------------------  -------  ------  -------
eodag/extensions/filter.py      +21      -1  +2.34%
TOTAL                           +21      -1  +0.26%

Results for commit: 1ccf6b3

Minimum allowed coverage is 70%

♻️ This comment has been updated with latest results

@anesson-cs
anesson-cs force-pushed the cop-ghsl-queryables branch from 0908959 to 912a755 Compare August 18, 2026 17:34
@anesson-cs
anesson-cs requested a review from alambare August 18, 2026 17:40
@anesson-cs
anesson-cs force-pushed the cop-ghsl-queryables branch from 912a755 to 1ccf6b3 Compare August 19, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant