fix: handle queryables ecmwf properties for not-ecmwf federation backends - #132
Open
anesson-cs wants to merge 1 commit into
Open
fix: handle queryables ecmwf properties for not-ecmwf federation backends#132anesson-cs wants to merge 1 commit into
anesson-cs wants to merge 1 commit into
Conversation
Contributor
Contributor
Code CoverageDetailsDiff against mainResults for commit: 1ccf6b3 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
anesson-cs
force-pushed
the
cop-ghsl-queryables
branch
from
August 18, 2026 17:34
0908959 to
912a755
Compare
anesson-cs
force-pushed
the
cop-ghsl-queryables
branch
from
August 19, 2026 13:10
912a755 to
1ccf6b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an
ECMWFproperty was returned as a queryable of a federation backend not having theECMWFSearchplugin, it was still the same as if it was for anECMWFfederation backend.For instance, the request
/collections/GHS_SMOD/queryables?provider=cop_ghslreturnedecmwf:yearinstead ofyearin queryables properties.This issue is fixed now with corresponding tests.
However, a thinking may be done about the necessity to add this level of complexity on the server to handle queryables in general.