Skip to content

fix: remove federation extension link as it is not valid - #122

Merged
alambare merged 2 commits into
mainfrom
fix/stac-extensions-null
Aug 11, 2026
Merged

fix: remove federation extension link as it is not valid#122
alambare merged 2 commits into
mainfrom
fix/stac-extensions-null

Conversation

@alambare

@alambare alambare commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

The stac_extensions field must only contain non-empty strings per the STAC spec. This regression test ensures no null or empty values are ever returned in the landing page response.

Fix: #114

En attente de: CS-SI/eodag#2272 After discussion, we decided to not include the extension link until OpenEO provides valid extension links.

cf: Open-EO/openeo-api#598

@alambare alambare added the bug Something isn't working label Jul 15, 2026
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Test Results

  4 files  ±0    4 suites  ±0   1m 36s ⏱️ +8s
114 tests ±0  114 ✅ ±0  0 💤 ±0  0 ❌ ±0 
456 runs  ±0  456 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1db1c5c. ± Comparison against base commit a185802.

♻️ This comment has been updated with latest results.

@alambare
alambare marked this pull request as draft July 15, 2026 11:53
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

badge

Code Coverage

Details
Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------
eodag/__init__.py                            0       0  100.00%
eodag/app.py                                73      15  79.45%   122, 136-143, 154-156, 212-224, 228
eodag/client.py                             24       0  100.00%
eodag/config.py                             19       0  100.00%
eodag/constants.py                           5       0  100.00%
eodag/core.py                              318      27  91.51%   136-137, 147, 293-294, 384, 518-519, 538, 581, 667, 683-687, 701-705, 707-711, 716, 729, 739-741, 744-745, 755, 758, 774
eodag/cql_evaluate.py                       48      18  62.50%   48, 53, 58, 75, 78, 81, 86-99, 105
eodag/dag.py                                57       0  100.00%
eodag/errors.py                             94       7  92.55%   145, 162-165, 181, 205
eodag/logs.py                               62       9  85.48%   40-49, 105
eodag/middlewares.py                        32       2  93.75%   20, 24
eodag/telemetry.py                          44       0  100.00%
eodag/utils.py                              41      10  75.61%   44, 69, 72-73, 86, 90-98, 134
eodag/eodag_types/__init__.py                0       0  100.00%
eodag/eodag_types/queryables.py             42       8  80.95%   46, 50-51, 61, 77-81
eodag/eodag_types/search.py                 25      25  0.00%    20-69
eodag/extensions/collection_order.py        71       1  98.59%   102
eodag/extensions/data_download.py          121      42  65.29%   61-73, 94, 112-113, 120, 135-142, 147-148, 155-187, 195-198
eodag/extensions/filter.py                 106      10  90.57%   185-186, 228, 286-287, 307, 315, 321, 339-341
eodag/extensions/offset_pagination.py       12       0  100.00%
eodag/models/__init__.py                     0       0  100.00%
eodag/models/item.py                        76       6  92.11%   47-50, 52, 64
eodag/models/links.py                      148      13  91.22%   39, 93-95, 201, 219, 251, 299, 348-359
eodag/models/stac_metadata.py                5       0  100.00%
TOTAL                                     1423     193  86.44%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  --------
eodag/client.py       -1       0  +100.00%
TOTAL                 -1       0  -0.01%

Results for commit: 1db1c5c

Minimum allowed coverage is 70%

♻️ This comment has been updated with latest results

@alambare
alambare force-pushed the fix/stac-extensions-null branch from 86babc1 to b097984 Compare July 15, 2026 12:21
@alambare
alambare force-pushed the fix/stac-extensions-null branch from 42ecf61 to 1db1c5c Compare August 11, 2026 10:17
@alambare alambare changed the title test: ensure stac_extensions contains no null values fix: remove federation extension link as it is not valid Aug 11, 2026
@alambare
alambare marked this pull request as ready for review August 11, 2026 10:20
@alambare
alambare merged commit 1db1c5c into main Aug 11, 2026
13 checks passed
@alambare
alambare deleted the fix/stac-extensions-null branch August 11, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

violation of the specification

1 participant