Skip to content

fix: add downloadLink asset independetly of the presence of eodag:download_link - #121

Merged
alambare merged 4 commits into
mainfrom
always-add-download-link
Aug 11, 2026
Merged

fix: add downloadLink asset independetly of the presence of eodag:download_link#121
alambare merged 4 commits into
mainfrom
always-add-download-link

Conversation

@dalpasso

@dalpasso dalpasso commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

The downloadLink asset should be shown for all providers (except some specific asset types). The product must be online to have a download link, i.e. it's not added if the product is on staging or offline. If eodag:download_link is missing, the proxy link is used if available.

@dalpasso dalpasso self-assigned this Jul 15, 2026
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Test Results

  4 files  ±0    4 suites  ±0   1m 39s ⏱️ +28s
116 tests +1  116 ✅ +1  0 💤 ±0  0 ❌ ±0 
464 runs  +4  464 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit e2e2a56. ± Comparison against base commit a6f7ac3.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

badge

Code Coverage

Details
Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------
eodag/__init__.py                            0       0  100.00%
eodag/app.py                                73      15  79.45%   122, 136-143, 154-156, 212-224, 228
eodag/client.py                             24       0  100.00%
eodag/config.py                             19       0  100.00%
eodag/constants.py                           5       0  100.00%
eodag/core.py                              318      27  91.51%   136-137, 147, 293-294, 384, 518-519, 538, 581, 668, 684-688, 702-706, 708-712, 717, 730, 740-742, 745-746, 756, 759, 775
eodag/cql_evaluate.py                       48      18  62.50%   48, 53, 58, 75, 78, 81, 86-99, 105
eodag/dag.py                                57       0  100.00%
eodag/errors.py                             94       7  92.55%   145, 162-165, 181, 205
eodag/logs.py                               62       9  85.48%   40-49, 105
eodag/middlewares.py                        32       2  93.75%   20, 24
eodag/telemetry.py                          44       0  100.00%
eodag/utils.py                              41      10  75.61%   44, 69, 72-73, 86, 90-98, 134
eodag/eodag_types/__init__.py                0       0  100.00%
eodag/eodag_types/queryables.py             42       8  80.95%   46, 50-51, 61, 77-81
eodag/eodag_types/search.py                 25      25  0.00%    20-69
eodag/extensions/collection_order.py        71       1  98.59%   102
eodag/extensions/data_download.py          121      42  65.29%   61-73, 94, 112-113, 120, 135-142, 147-148, 155-187, 195-198
eodag/extensions/filter.py                 106      10  90.57%   185-186, 228, 286-287, 307, 315, 321, 339-341
eodag/extensions/offset_pagination.py       12       0  100.00%
eodag/models/__init__.py                     0       0  100.00%
eodag/models/item.py                        78       6  92.31%   47-50, 52, 64
eodag/models/links.py                      148      13  91.22%   39, 93-95, 201, 219, 251, 299, 348-359
eodag/models/stac_metadata.py                5       0  100.00%
TOTAL                                     1425     193  86.46%

Diff against main

Filename                Stmts    Miss  Cover
--------------------  -------  ------  -------
eodag/models/item.py       +2       0  +0.20%
TOTAL                      +2       0  +0.02%

Results for commit: e2e2a56

Minimum allowed coverage is 70%

♻️ This comment has been updated with latest results

@dalpasso
dalpasso requested review from jlahovnik and sbrunato July 15, 2026 14:28
@dalpasso
dalpasso force-pushed the always-add-download-link branch from 2b95762 to f4350ce Compare July 28, 2026 12:04
@alambare
alambare force-pushed the always-add-download-link branch from f4350ce to e2e2a56 Compare August 11, 2026 12:51
@alambare
alambare merged commit ce2b975 into main Aug 11, 2026
11 checks passed
@alambare
alambare deleted the always-add-download-link branch August 11, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants