fix: add downloadLink asset independetly of the presence of eodag:download_link - #121
Merged
Conversation
Contributor
Contributor
Code CoverageDetailsDiff against mainResults for commit: e2e2a56 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
dalpasso
force-pushed
the
always-add-download-link
branch
from
July 28, 2026 12:04
2b95762 to
f4350ce
Compare
jlahovnik
approved these changes
Jul 29, 2026
alambare
force-pushed
the
always-add-download-link
branch
from
August 11, 2026 12:51
f4350ce to
e2e2a56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
downloadLinkasset should be shown for all providers (except some specific asset types). The product must be online to have a download link, i.e. it's not added if the product is on staging or offline. Ifeodag:download_linkis missing, the proxy link is used if available.