ITG2e: after author proof corrections#80
Conversation
to Chapters 3.9 and 4.9 of International Tables G 2nd edition; some minor style changes to text of definitions; examples imported from external file topo_examples.cif.
to Chapters 3.9 and 4.9 of International Tables G 2nd edition; some
minor style changes to text of definitions; examples imported from
external file topo_examples.cif.
vaitkus
left a comment
vaitkus
left a comment
There was a problem hiding this comment.
Thank you for the PR. Since it is your first PR on this repository, the automated checks did not trigger and have to be approved by a person with a maintainer role (@jamesrhester should be able to help with this).
I do not have such a role on this repo, however, I was able to run the same checks locally on my machine and preemptively suggest a few changes to the PR. It is probably most convenient to accept or refuse these using the GitHub web interface.
Changes that I proposed in the Topology.dic file mainly deal with the deviations from the IUCr dictionary style guide (see https://github.com/COMCIFS/comcifs.github.io/blob/main/accepted/ddlm_dictionary_style_guide.md).
The data_ header proposed for the topo_examples.cif file is needed to make it a valid CIF file. Without the header some of the automated checks fail to run properly.
Thanks for these style fixes - Brian Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
Agreed that this distinguishes this version cleanly from the version published on the IUCr website. Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
3 participants
Suggested update to dictionary after receiving author proof corrections for International Tables G 2nd edition.
(1) Examples in category TOPOL imported from new topo_examples.cif file.
(2) Numerous small style changes (spelling, punctuation, addition of titles to references). These should be uncontroversial.
(3) Removal of _topol_link.net_id and _topol_net.overall_topology - these may need double-checking with authors.