Add data name to contain PaNET identifier for experimental technique.#586
Merged
jamesrhester merged 4 commits intoCOMCIFS:masterfrom Feb 23, 2026
Merged
Add data name to contain PaNET identifier for experimental technique.#586jamesrhester merged 4 commits intoCOMCIFS:masterfrom
jamesrhester merged 4 commits intoCOMCIFS:masterfrom
Conversation
vaitkus
requested changes
Feb 19, 2026
Collaborator
vaitkus
left a comment
vaitkus
left a comment
There was a problem hiding this comment.
Looks good overall, just a few minor suggestions.
I will also request a review from @paulmillar as the original submitter of the issue.
vaitkus
approved these changes
Feb 20, 2026
Collaborator
vaitkus
left a comment
vaitkus
left a comment
There was a problem hiding this comment.
The remaining suggestions would be nice to resolve, but are not blockers for sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #584.
If possible a more permanent citation (e.g. DOI) for PaNET would be preferable.