Merged
Conversation
vaitkus
reviewed
Jan 20, 2026
The_dictionary_author.email was moved to the end of the line due to it being of variable length.
Contributor
Author
|
As the other authors have been silent I think we can merge? |
Collaborator
|
@jamesrhester I agree, additional details can be added later is so desired. However, I was wondering if @nautolycus would like his ORCID to be added here as well, same as in the coreCIF dictionary? |
vaitkus
approved these changes
Feb 24, 2026
Collaborator
|
Happy for my ORCID to be added to any other pending changes. I tried to commit this change with a view to merging, but get syntax checking errors that I don't understand. Has an inline edit added some unnoticed whitespace? |
Collaborator
|
@nautolycus Thank you for the changes. I think it is more likely that the linter did not previously pickup on the incorrect formatting. I will update the layout and merge the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #2. Please add your email (if willing to release it) and ORCID (if available) by editing the PR.
Attention @rowlesmr @vaitkus @nautolycus .