Skip to content

refactor(ui): avoid leaking his in SidebarWindow constructor #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(ui): avoid leaking his in SidebarWindow constructor #12

wants to merge 1 commit into from

Conversation

hesphoros
Copy link

  • Removed direct use of his during setupUi() call.
  • Avoided passing his as parent to layout and child widgets.
  • Explicitly assigned parent-child relationships after full construction.
  • Improves safety and future maintainability of UI code.

@hesphoros
refactor(ui): avoid leaking his in SidebarWindow constructor
504845c 
- Removed direct use of 	his during setupUi() call.
- Avoided passing 	his as parent to layout and child widgets.
- Explicitly assigned parent-child relationships after full construction.
- Improves safety and future maintainability of UI code.
@hesphoros
Copy link
Author

Fix: avoid using this in SidebarWindow constructor

  • Removed use of this in constructor to avoid potential issues with partially constructed objects
  • Moved layout and widget setup into setupUi() using this internally
  • Ensured layout and children are correctly attached to SidebarWindow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hesphoros