Ian fixed history #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
App now catches the server response when a user submits a report and checks if an error message was returned. If so it'll display it to the user via an alert window.
Added new topic options for subscribing to cities/notification types on the settings page.
- Update Android platform to v9.0.0, which has androidX support enabled, hence no need for previous androidx support plugins.
- Update iOS platform to v6.2.0, which has wkwebview engine support enabled by default, hence no need for previous support plugins around it.
- Update the following plugins to their current latest versions:
- diagnostic: v6.0.3
- geolocation: v4.1.0
- splashscreen: v6.0.0
- firebasex: v12.0.0
App now catches the server response when a user submits a report and checks if an error message was returned. If so it'll display it to the user via an alert window.
Added new topic options for subscribing to cities/notification types on the settings page.
…/smell-my-city-cordova into ian-fixed-history
Currently old version of app is subscribed to "pghaqi" topic, to maintain compatability with old version we should continue subscribing to "pghaqi" until new notification changes have been pushed for a while.
App now pulls locations and notification topics from the server via an endpoint request. This means we can now add locations serverside and have those locations appear on the app without needing a new build everytime in the app store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly fixed git history of branch.
PR does the following:
-Error handling for smell report submission which returns old error messages if a custom error message isn't set by the rails server.
-Provides new notification topics for the user to subscribe to regarding specific cities/notification types.