-
Notifications
You must be signed in to change notification settings - Fork 27
BB2-4142: Make POST /authorize work by disabling CSRF #1376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4643d55
to
86d42c1
Compare
2f0b7b3
to
49c6923
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked great, thanks for the detailed verification steps. I'm realizing that using curl for POST authorize probably will never really work, just don't see how that would ever bring us to the medicare login, but I think that's okay. We ought to find a place to put this kind of example, maybe let's talk about it (and have you demo the js test app) during sprint demo and see if the product team wants to proceed with something like working this into the test client or sample clients.
Had just one comment to make sure that we aren't dependent on the feature flag to enforce state
for these POST commands.
8d3b181
to
6285c88
Compare
6285c88
to
9ed3fc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, as long as the tests pass, we should be good here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapproving, pending successful tests.
JIRA Ticket:
BB2-4142
What Does This PR Do?
This PR updates the authorization views to explicitly allow POST requests on the /authorize endpoint without CSRF protection
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Validation
server.js
Steps to start app
4a.
node server.js
Now you can make Authorize and see if its generating token
<input type="hidden" name="state" value="${state}" />
to validate state parameter is requiredWhat Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)