BCDA-9401: remove denylist init and rename #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cancelFunc context.CancelFunc // used to clean up resources associated with the ticker | ||
| ) | ||
|
|
||
| type CacheConfig struct { |
There was a problem hiding this comment.
this file contains the init() code changes vs just renames.
| ALTER SEQUENCE denylist_entries_id_seq | ||
| RENAME TO blacklist_entries_id_seq ; | ||
|
|
||
| COMMIT; |
There was a problem hiding this comment.
We should make a special note in the deploy following this merge that in the case of the need to revert to a previous release we will need to manually run this down migration.
bhagatparwinder
previously approved these changes
Sep 4, 2025
carlpartridge
approved these changes
Sep 4, 2025
michaeljvaldes
approved these changes
Sep 5, 2025
bhagatparwinder
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-9401
🛠 Changes
tokendenylist.goremovedℹ️ Context
Part of effort to reduce init() usage across bcda repos to enable more effective testing.
Pre Deployment Notice
🧪 Validation
All tests passing.