Jmafoster1/388 fix large scenarios#395
Conversation
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| black | 38 | 1 | 1.05s | ||
| ✅ PYTHON | pylint | 38 | 0 | 5.06s |
See detailed report in MegaLinter reports
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
==========================================
+ Coverage 98.15% 98.18% +0.02%
==========================================
Files 31 32 +1
Lines 1841 1704 -137
==========================================
- Hits 1807 1673 -134
+ Misses 34 31 -3
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
| estimator_map = {ff.name: ff for ff in entry_points(group="estimators")} | ||
| effect_map = {ff.name: ff for ff in entry_points(group="causal_effects")} |
There was a problem hiding this comment.
How big is this list comp? is it efficient to be using a dict here?
There was a problem hiding this comment.
They're both pretty small, like 5 elements. The entrypoints are defined in the corresponding entries in pyproject.toml. What would you propose to use instead?
Closes #388.
This has turned into a bit of a monster PR. Main changes as follows:
CausalTestingFrameworkclass is now a "first class citizen". It is designed and intended to be used as a standalone API rather than purely as part of the commandline interface.CausalTestCases now have some extra instance attributes:execute_testas an instance variable instead of returning it. This means you don't have to iterate azipobject of the tests and their associated results.nameandskipattributes from the JSON frontend. This means that there's now a 1:1 mapping between tests and their representation in JSON, meaning that we don't need to keep the parsed input around for later use as part of output.