DNM: tests: make each test family optional #533
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwf
force-pushed
the
202505-optionalize_tests
branch
3 times, most recently
from
604c34d to
38a5acd
Compare
We'll have xmake generate this for us shortly
nwf
force-pushed
the
202505-optionalize_tests
branch
3 times, most recently
from
491a2ef to
544755a
Compare
Make each test's presence configurable via xmake. By default, all tests
will be included and some can be notched out with one or more
`--test-${test}=n` options. Use `--all-tests=n` to flip the default,
generating a test suite binary including only those particular tests
specified with `--test-${test}=y`. Use `xmake f --help` to see the list
of `${test}`s.
While here, have xmake generate our test compartment entry prototypes
and the actual run_timed calls.
Also while here, now that we can test such things, push dependencies
down to each test where possible.
nwf
force-pushed
the
202505-optionalize_tests
branch
from
544755a to
a47b865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make each test's presence configurable via xmake. By default, all tests will be included and some can be notched out with one or more
--test-${test}=noptions. Use--all-tests=nto flip the default, generating a test suite binary including only those particular tests specified with--test-${test}=y. Usexmake f --helpto see the list of${test}s.Perhaps hold off on merging until there's some better guidance from xmake upstream about
option()handling; see xmake-io/xmake#6419 .Review of the general approach is, however, quite welcome.