Skip to content

Make polyhedron_3_to_lcc() generic for FaceGraph - #9582

Open
afabri wants to merge 1 commit into
CGAL:mainfrom
afabri:LCC-read_face_graph-GF
Open

Make polyhedron_3_to_lcc() generic for FaceGraph#9582
afabri wants to merge 1 commit into
CGAL:mainfrom
afabri:LCC-read_face_graph-GF

Conversation

@afabri

@afabri afabri commented Jul 31, 2026

Copy link
Copy Markdown
Member

Summary of Changes

While reviewing the hex mesh code I saw that the function reading a polyhedron should be generalized.

Todo

  • Move part of the header to the LCC package. There are two other functions in there.

Release Management

  • Affected package(s): LCC
  • License and copyright ownership: unchanged

@afabri
afabri requested a review from gdamiand July 31, 2026 12:42
@afabri afabri self-assigned this Jul 31, 2026
@afabri

afabri commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

/build:v0

@github-actions

Copy link
Copy Markdown

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9582/v0/Manual/index.html

@gdamiand gdamiand left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the function (and of the file) should be changed?
face_graph_to_lcc?

@afabri afabri changed the title Make read_face_graph_in_lcc_3() generic for FaceGraph Make read_polyhedron_in_lcc_3() generic for FaceGraph Jul 31, 2026
@afabri afabri changed the title Make read_polyhedron_in_lcc_3() generic for FaceGraph Make polyhedron_3_to_lcc() generic for FaceGraph Jul 31, 2026
@sloriot

sloriot commented Jul 31, 2026

Copy link
Copy Markdown
Member

Strange copy_face_graph() does not work...

@afabri

afabri commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Strange copy_face_graph() does not work...

Good point. I give it a try, but immaediately get errors when just adding
#include <CGAL/boost/graph/graph_traits_Linear_cell_complex_for_combinatorial_map.h>

In fact it needs this typedef:

typedef CGAL::Linear_cell_complex_for_bgl_combinatorial_map_helper<2, 3, MyTraits>::type LCC;

And this shows that the functions do not do the same. The LCC for copy_face_graph() does not represent a volume.
Question to Guillaume: What happens when the surface has a border?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants