Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 18, 2025

CI builds fail on macOS (arm64) and Windows due to dependency version conflicts. CGAL is installed from source against conda's GMP/MPFR/TBB, but the build then requests different versions from Conan, causing linker failures.

Changes

  • setup.py: When CGAL_PYTHON_MODULE_VERSION is set (CI builds), use empty Conan requirements list instead of requesting gmp/mpfr
    • CI builds now use pre-installed CGAL with conda dependencies (no version conflicts)
    • User installs unchanged: still get full cgal package from Conan with bundled dependencies
# Before
conan_requirements=["cmake/[>=3.12 <4]"] + (["gmp/[>=6.3]", "mpfr/[>=4.2]"] if os.environ.get(
    'CGAL_PYTHON_MODULE_VERSION') else ["cgal/[>=6.0 <7.0]"])

# After
conan_requirements=["cmake/[>=3.12 <4]"] + ([] if os.environ.get(
    'CGAL_PYTHON_MODULE_VERSION') else ["cgal/[>=6.0 <7.0]"])

Impact

Resolves linker errors:

  • macOS: undefined GMP/MPFR symbols (___gmpn_*, ___gmpq_*, _mpfr_*)
  • Windows: missing tbb12.lib

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix build issues on MacOS and Windows platforms Fix CI build failures: remove conflicting Conan dependencies in CI builds Nov 18, 2025
Copilot AI requested a review from lrineau November 18, 2025 12:31
Copilot finished work on behalf of lrineau November 18, 2025 12:31
@lrineau lrineau force-pushed the copilot/sub-pr-286-again branch from 570e1f2 to d868b78 Compare November 18, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants