tests: test_iffeature_state crash fix #141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradh352
changed the title
As observed on Debian Trixie RC2, test_iffeature_state crashes due to an internal pointer being invalidated. This invalidation appears to be due to a call to lys_set_implemented() possibly causing a full recompile of the ctx. This simply reorders the caching of the path pointers so they are not invalidated when used. Signed-off-by: Brad House <[email protected]>
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jul 6, 2025
There is an internal Python CFFI pointer that gets invalidated in a test case due to the internal object being mutated. This test case appears to be malformed and makes incorrect assumptions. Nothing here in particular appears to be actually related to Trixie so it isn't clear why it shows up. The feature being tested is also in a code path that is not used at all by SONiC. CESNET/libyang-python#141 Signed-off-by: Brad House <[email protected]>
7 tasks
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jul 7, 2025
There is an internal Python CFFI pointer that gets invalidated in a test case due to the internal object being mutated. This test case appears to be malformed and makes incorrect assumptions. Nothing here in particular appears to be actually related to Trixie so it isn't clear why it shows up. The feature being tested is also in a code path that is not used at all by SONiC. CESNET/libyang-python#141 Signed-off-by: Brad House <[email protected]>
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jul 8, 2025
There is an internal Python CFFI pointer that gets invalidated in a test case due to the internal object being mutated. This test case appears to be malformed and makes incorrect assumptions. Nothing here in particular appears to be actually related to Trixie so it isn't clear why it shows up. The feature being tested is also in a code path that is not used at all by SONiC. CESNET/libyang-python#141 Signed-off-by: Brad House <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As observed on Debian Trixie RC2, test_iffeature_state crashes due to an internal pointer being invalidated. This invalidation appears to be due to a call to lys_set_implemented() possibly causing a full recompile of the ctx.
This simply reorders the caching of the path pointers so they are not invalidated when used.
Fixes #140